Fix wrong declaration of jv_string_value - #103
Closed
FantasqueX wants to merge 1 commit into
Closed
FantasqueX wants to merge 1 commit into
FantasqueX wants to merge 1 commit into
Conversation
Currently, there is a warning when building wheel.
```
jq.c: In function ‘__pyx_f_2jq_jv_string_to_py_string’:
jq.c:12111:24: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
12111 | __pyx_v_string_value = jv_string_value(__pyx_v_value);
|
```
This is because the type of return value of `jv_string_value` is `const
char *` instead of `char *`. This is not an API change. The function
returns `const char *` when it becomes available.
Owner
|
Thanks for the report, this has since been fixed on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is a warning when building wheel.
This is because the type of return value of
jv_string_valueisconst char *instead ofchar *. This is not an API change. The function returnsconst char *when it becomes available.