Fix linking failures on Windows/MSYS2 - #135
Conversation
mwilliamson
left a comment
There was a problem hiding this comment.
I might have misunderstood something, but I think this set of changes conflates two things:
-
Fixing the failures on more recent versions of setup-msys2 by setting
PATHfor all architectures, not just x86. -
Other changes to how the action is used in preparation for #134.
I know virtually nothing about msys2 but will be ultimately responsible for keeping things working, so it would be useful for me to understand changes like using install vs pacboy in the setup-msys2 action, which I assume (perhaps incorrectly!) fall under (2)? But I don't think that needs to be a blocker in getting #132 fixed.
|
To clarify the bit about So it's a bit of a grey area whether those changes belong to classification 1 or 2. The absolute minimum set of changes to fix the link issue would simply be to prepend the MSYS2 path; the other changes are simplifying the package lookup. Let me know if you'd like the bare minimum change here instead, and I can move the other changes over to #134. |
|
Gotcha! Thanks for the explanation. Let's keep this change minimal then, in the spirit of only changing one thing at a time, and the restructuring can happen elsewhere. |
6bac7c7 to
56a9933
Compare
56a9933 to
145c716
Compare
|
Sure, done -- I have reduced this patch to the minimal set of changes required to fix #132. |
|
Thanks! |
Fixes #132. My hypothesis is that the link errors were caused by
libjqbeing built with the MSYS2 toolchain while the extension was linked by the mingw-w64 shipped in the runner image atC:\mingw64. The fix is simply to prepend the MSYS2 environment'sbindirectory to thePATHunconditionally.I've also restructured the action a bit in preparation for adding ARM64 builds in #134.
Passing build on my fork.