fix(redis): accept REDIS_URL for TLS providers - #2805
Open
poboll wants to merge 1 commit into
Open
Conversation
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
poboll
force-pushed
the
codex/redis-url-tls-compat-20260811
branch
from
August 11, 2026 01:23
fdeff70 to
4a96c99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
REDIS_URLas a provider-compatible alias forREDIS_CONNECTION_STRINGREDIS_CONNECTION_STRING, thenREDIS_CONNECTION, thenREDIS_URLrediss://TLS configuration for managed providers such as UpstashRoot cause
Core already enables TLS when a connection string uses the
rediss://scheme. However, the runtime and Docker entrypoint did not consume the provider-standardREDIS_URLvariable, while the documentation only listed host, port, and password settings. An Upstash deployment using the suppliedREDIS_URLtherefore fell back to a non-TLS local/host configuration and repeatedly timed out.Implementation
Verification
pnpm -C apps/core exec vitest run src/utils/redis-config.util.spec.ts(4 tests passed)pnpm -C apps/core run typecheckpnpm -C apps/core run buildREDIS_URL, alias precedence, and masked loggingbash -n docker-entrypoint.shgit diff --checkFixes #2762