Repository navigation
Conversation
Collaborator
Author
|
Depends on nats-io/jsm.go#877 |
ploubser
force-pushed
the
jsm_issue_874
branch
from
October 22, 2026 09:31
13fd9ef to
f151f99
Compare
audit gather could only collect every profile or none. Users can now list the profiles they want, or leave some out of the default set. Settings can also come from a YAML file, given on the command line or through an environment variable, so a site can keep a safe setup that every gather uses. Flags given on the command line override the file. goroutine_2 is no longer collected by default. Signed-off-by: Pieter Loubser <ploubser@gmail.com>
ploubser
force-pushed
the
jsm_issue_874
branch
from
October 22, 2026 09:36
f151f99 to
0559b88
Compare
ripienaar
reviewed
Oct 22, 2026
|
|
||
| gather := app.Command("gather", "capture a variety of data from a deployment into an archive file").Alias("capture").Alias("cap").Action(c.gather) | ||
| gather.Tag("scope:system", "impact:ro") | ||
| gather.Flag("config", "YAML file to read gather settings from").Envar("NATS_AUDIT_GATHER_CONFIG").PlaceHolder("FILE").ExistingFileVar(&c.configFile) |
Collaborator
There was a problem hiding this comment.
its hard to know what goes in this file, perhaps we should add a --write-config or something so people can make it using the flags? Then perhaps JSON would be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audit gather could only collect every profile or none. Users can now list the profiles they want, or leave some out of the default set.
Settings can also come from a YAML file, given on the command line or through an environment variable, so a site can keep a safe setup that every gather uses. Flags given on the command line override the file.
goroutine_2 is no longer collected by default.