Feat/为event_mixin添加wait_private_event和wait_group_event支持 (issue #24) - #54
Merged
GEYUANwuqi merged 2 commits intoAug 23, 2026
Conversation
Member
|
感谢贡献, 当前实现存在阻塞性问题, 不会进行合并:
建议参考以下方式调整:
修改完成后, 请将当前提交整理为一个 commit , 并将 pr 由 draft 状态变更为 open, 测试和文档可以借助AI完成, 但请确认测试确实覆盖新增方法并能够复现其行为 |
GEYUANwuqi
marked this pull request as draft
August 22, 2026 14:21
SulfurQWQ
force-pushed
the
feat/support-wait_private_event-wait_group_event
branch
from
August 23, 2026 04:15
d93b5c6 to
c259ae5
Compare
SulfurQWQ
marked this pull request as ready for review
August 23, 2026 04:16
Author
|
已完成对应修改喵 -提取 _wait_entity 通用方法,利用 TypeVar 实现泛型推导 测试日志如下 |
Member
|
还是有点小问题, 不过整体方向是对的, 我先合并了, 你后续可以看看是怎么改的 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改说明:
为EventMixin 支持内置的 wait_xxx_event 模式以提供便捷类型支持 (issue #24)
关联Issue:
issue #24
测试情况:
本地运行的 event_mixin 相关单元测试已通过
点击展开 pytest 运行日志
(ncatbot5) [Sulfur@archlinux NcatBot]$ pytest tests/unit/**/test_*event_mixin*.py =========================================================================================================== test session starts ============================================================================================================ platform linux -- Python 3.14.7, pytest-9.1.1, pluggy-1.6.0 rootdir: /home/Sulfur/Desktop/ncatbotWork/NcatBot configfile: pyproject.toml plugins: metadata-3.1.1, cov-7.1.0, html-4.2.0, asyncio-1.4.0, anyio-4.14.2 asyncio: mode=Mode.AUTO, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function collected 5 itemstests/unit/plugin/test_event_mixin.py ..... [100%]
============================================================================================================ 5 passed in 0.09s =============================================================================================================
第一次提交代码,如果有不妥的地方请告诉我谢谢喵