Repository navigation
Fix 2DGS projection backward on non-contiguous gradients - #1098
Open
nicolaihaeni wants to merge 1 commit into
Open
nicolaihaeni wants to merge 1 commit into
nicolaihaeni wants to merge 1 commit into
Conversation
projection_2dgs_fused_bwd required its incoming gradients to be contiguous, but autograd can hand in non-contiguous ones (e.g. for depths when normals or the distortion loss are rendered), which raised "grad.depths must be contiguous". Make them contiguous first, as the 3DGS backward already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projection_2dgs_fused_bwd checks its incoming gradients with CHECK_INPUT, which requires them to be contiguous. Autograd can hand in non-contiguous ones, e.g. for depths when the normals or the distortion loss are used, so 2DGS training with the normal/distortion regularizers (as in simple_trainer_2dgs.py) fails with
RuntimeError: grad.depths must be contiguous
This makes the gradients contiguous before the check, as the 3DGS backward (projection_ewa_3dgs_fused_bwd) already does.
Repro (fails on main at backward()):