Skip to content

feat: add Cells script metadata for mainnet and testnet - #2951

Open
joii2020 wants to merge 3 commits into
nervosnetwork:developfrom
joii2020:dev-cells-scripts
Open

joii2020 wants to merge 3 commits into
nervosnetwork:developfrom
joii2020:dev-cells-scripts

Conversation

@joii2020

Copy link
Copy Markdown

No description provided.

@LusoCryptoLabs

Copy link
Copy Markdown

Checked the eight outpoints at a512fa4 on mainnet and testnet: each cell is live, and its type script hash equals the code hash beside it. Thanks @joii2020.

@chenyukang
chenyukang enabled auto-merge November 11, 2026 03:14
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (f373f6b) to head (71c01c7).
⚠️ Report is 989 commits behind head on develop.

❌ Your project check has failed because the head coverage (0.00%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (71c01c7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (71c01c7)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #2951       +/-   ##
===========================================
- Coverage    67.56%   0.00%   -67.57%     
===========================================
  Files          289     293        +4     
  Lines         7944   14766     +6822     
===========================================
- Hits          5367       0     -5367     
- Misses        2577   14766    +12189     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LusoCryptoLabs

Copy link
Copy Markdown

Two of these out points changed on 2026-11-06, when Cells Account and Cells Sale Lock were upgraded through their type id. The code hash stays the same; the code cell is new, on both networks:

script network in this PR (now dead) current
Cells Account mainnet 0x3072417e...bf0b-0 0x0d48aa833f97aa1c10f803c03a58e32b4184556f0ddba3137b014aa48df55109-0
Cells Sale Lock mainnet 0x020f7f9e...cabb-0 0xe72ac6421e9b9cd582dda77383ca0f100d7e05f1f08ae191d1f3b569f35ab7da-0
Cells Account testnet 0xe3c20494...cce4-0 0x1d791fd5f8edfa9199346ff8ec19d0d341a3adb4f43c26ea32a4d59b94fc1eab-0
Cells Sale Lock testnet 0x03507c8c...b0fc-0 0x279ab20ee45be9a58be6cb5cfecfc16d368ca03b62e6f115f48a55e0bb161e40-0

scripts#index returns Contract.live_verified, so with only the old out points these two would be verified on dead cells and left out of the list. Keeping the old out point and adding the current one, as in nervosnetwork/ckb-explorer-frontend#2143, covers both. Cells Account Lock and Cells Price did not change.

Checked with get_live_cell on both networks: the old cells are spent, the current ones are live and their type script hash equals the code hash in this PR. The mainnet API agrees (scripts/deployed_cells lists the old cells as dead and does not list the current ones yet).

On testnet, scripts/general_info returns 404 for Cells Account, Cells Account Lock and Cells Sale Lock (Cells Price returns 200), so the task will print those three as errors until they are indexed.

@LusoCryptoLabs

Copy link
Copy Markdown

@joii2020 477cf5b still lists the four out points from my comment above, which are spent on both networks; the current ones in that table are live. Could you update them before this is merged?

auto-merge was automatically disabled November 18, 2026 11:46

Head branch was pushed to by a user without write access

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants