Skip to content

Moving up chapter "Události" + highlight heading#1064

Closed
mildabre wants to merge 150 commits into
nette:masterfrom
mildabre:patch-21
Closed

Moving up chapter "Události" + highlight heading#1064
mildabre wants to merge 150 commits into
nette:masterfrom
mildabre:patch-21

Conversation

@mildabre

@mildabre mildabre commented Nov 3, 2024

Copy link
Copy Markdown
Contributor

Presenter events are important and should be used as standard even in simpler applications, typically in conjunction with trait usage. Therefore, I suggest:

  • highlight the section title to the top level, so that this topic is permanently visible in the side menu
  • move the section higher, roughly to a place corresponding to its meaning (before the request parameters)

@dg dg force-pushed the master branch 29 times, most recently from e0bc7f4 to 3c92c82 Compare December 18, 2024 14:49
@dg

dg commented Jul 5, 2026

Copy link
Copy Markdown
Member

Thanks — I agree the Events section was in an odd spot. Rather than promoting it to a top-level heading and moving it before "Request Parameters", I moved it to the end of the Presenter Life Cycle chapter (164e96e59, both languages). That's where it belongs thematically: $onStartup/$onRender/$onShutdown hook directly into the startup()/beforeRender()/shutdown() methods documented right above it, so the reader meets the events immediately after the lifecycle methods they wrap. It's now grouped with them rather than sitting among the unrelated deep-dive topics. Closing since the branch can't be merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.