Skip to content

editor:// script: document ECMA version used on Windows#1080

Closed
mabar wants to merge 189 commits into
nette:masterfrom
mabar:patch-2
Closed

editor:// script: document ECMA version used on Windows#1080
mabar wants to merge 189 commits into
nette:masterfrom
mabar:patch-2

Conversation

@mabar

@mabar mabar commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

I was fighting with the syntax for some time and though it would be good to document.


Btw, alert box for notes seems to be broken - https://doc.nette.org/en/contributing/syntax#toc-boxes-and-styles
image

@dg dg force-pushed the master branch 29 times, most recently from 56a7648 to b009df4 Compare October 22, 2025 20:45
@dg

dg commented Jul 5, 2026

Copy link
Copy Markdown
Member

Great catch, thanks. Verified against tools/open-in-editor/windows/open-editor.js (it's ES3-style var settings = {…} run via WSH). Incorporated in 6ab8c3468: added a .[caution] box explaining the JScript/ECMA-262 3rd Edition limitation (no let/const, no arrow functions, no trailing comma), and extended the mapping example with a second entry so it no longer ends with a trailing comma — matching the caution. Closing since the branch can't be merged directly (predates force-pushes).

(Re the broken alert box on the syntax page — that's a separate rendering issue, tracked outside this PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.