Skip to content

insns: fix CCMP immediate template ordering and add CTEST reg, mem symmetry #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agourakis82 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

insns: fix CCMP immediate template ordering and add CTEST reg, mem symmetry #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30304af
insns: fix CCMP immediate template ordering and add CTEST reg, mem sy…
agourakis82 Sep 23, 2026
6d9804c
test(apx): add regression fixtures for unsized memory CCMP and CTEST …
agourakis82 Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions travis/apx-ccmpscc/apx-ccmpscc.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,3 +1004,6 @@ testcase {0x62, 0xDC, 0x7D, 0x04, 0x83, 0x3A, 0x05}, {ccmpz{dfv=cf,zf,sf,of} wor
testcase {0x62, 0xDC, 0x7C, 0x04, 0x83, 0x3A, 0x05}, {ccmpz{dfv=cf,zf,sf,of} dword [r26], byte 0x05}
testcase {0x62, 0xDC, 0xFC, 0x04, 0x83, 0x3A, 0x05}, {ccmpz{dfv=cf,zf,sf,of} qword [r26], byte 0x05}


; Unsized memory operand with explicit byte immediate (issue #316)
testcase {0x62, 0xF4, 0x04, 0x02, 0x80, 0x3C, 0x24, 0x0A}, {ccmpb {dfv=} [rsp], byte 10}
Binary file modified travis/apx-ccmpscc/apx-ccmpscc.bin.t
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions travis/apx-ctestscc/apx-ctestscc.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,3 +555,6 @@ testcase {0x62, 0xDC, 0x7C, 0x04, 0xF6, 0x02, 0x05}, {ctestz{dfv=cf,zf,sf,of} by
testcase {0x62, 0xDC, 0x7D, 0x04, 0xF7, 0x02, 0x05, 0x00}, {ctestz{dfv=cf,zf,sf,of} word [r26], word 0x05}
testcase {0x62, 0xDC, 0x7C, 0x04, 0xF7, 0x02, 0x05, 0x00, 0x00, 0x00}, {ctestz{dfv=cf,zf,sf,of} dword [r26], dword 0x05}
testcase {0x62, 0xDC, 0xFC, 0x04, 0xF7, 0x02, 0x05, 0x00, 0x00, 0x00}, {ctestz{dfv=cf,zf,sf,of} qword [r26], dword 0x05}

; Register-memory operand order symmetry (canonical 84 /r encoding)
testcase {0x62, 0xF4, 0x04, 0x02, 0x84, 0x0A}, {ctestb {dfv=} cl, [rdx]}
Binary file modified travis/apx-ctestscc/apx-ctestscc.bin.t
View file
Open in desktop
Binary file not shown.
4 changes: 3 additions & 1 deletion x86/insns.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,10 +962,12 @@ XLAT void [ d7] 8086,ND

$bwdq CCMPscc spec4,rm#,reg# [wmr: evex.scc.dfv.l0.m4.o# 38# /r ] APX,SM1-2
$bwdq CCMPscc spec4,reg#,rm# [wrm: evex.scc.dfv.l0.m4.o# 3a# /r ] APX,SM1-2
CCMPscc spec4,rm8,imm8 [wmi: evex.scc.dfv.l0.m4.o8 80 /7 ib ] APX,SM1-2
Comment thread
agourakis82 marked this conversation as resolved.
Resolved
$wdq CCMPscc spec4,rm#,sbyte# [wmi: evex.scc.dfv.l0.m4.o# 83 /7 ib,s ] APX,SM1-2
$bwdq CCMPscc spec4,rm#,imm# [wmi: evex.scc.dfv.l0.m4.o# 80# /7 i# ] APX,SM1-2
$wdq CCMPscc spec4,rm#,imm# [wmi: evex.scc.dfv.l0.m4.o# 81 /7 i# ] APX,SM1-2

$bwdq CTESTscc spec4,rm#,reg# [wmr: evex.scc.dfv.l0.m4.o# 84# /r ] APX,SM1-2
$bwdq CTESTscc spec4,reg#,mem# [wrm: evex.scc.dfv.l0.m4.o# 84# /r ] APX,SM1-2,ND
Comment thread
agourakis82 marked this conversation as resolved.
Resolved
$bwdq CTESTscc spec4,rm#,imm# [wmi: evex.scc.dfv.l0.m4.o# f6# /0 i# ] APX,SM1-2
$bwdq CTESTscc spec4,rm#,imm# [wmi: evex.scc.dfv.l0.m4.o# f6# /1 i# ] APX,SM1-2

Expand Down