Repository navigation
Conversation
The APX cpu flag was only checked when an instruction needed REX2 for
registers r16-r31. The other APX forms (new data destination, {nf},
PUSH2/POP2, CCMP, CFCMOV, JMPABS) carry the APX template flag but it
was never checked, so "cpu noapx" still emitted them. Check it in
matches() next to the cpu level check.
Also document the APX cpu flag and fix two typos in the VEX entry.
Related to netwide-assembler#328.
Signed-off-by: Zane Hambly <zanehambly@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! "cpu noapx" only blocked APX when an instruction needed REX2 for
r16-r31, so the other APX forms (NDD, {nf}, PUSH2/POP2, CCMP, CFCMOV,
JMPABS) still got emitted. This checks the APX template flag in matches()
next to the cpu level check, and adds a travis/cpuapx test that fails
without the fix. I've also documented the APX cpu flag and fixed two
typos in the VEX entry. Related to #328.