Add KPN provider, xlsx parser and tests - #433
Conversation
|
Thanks for this one @mkekez-SIE. CI is green across 3.10–3.14, the changelog fragment is in place, and the branch is current with The one I care most about is the timezone. Two more on the parser:
Two small ones while you're in there:
The structure itself is in good shape: the Dutch status map, impact from downtime minutes, and the required-column check are all the right approach. Let me know if I've read the timezone piece wrong. |
|
Hey @jvanderaa - Thanks for taking a look at this. Ahh yes - the timezone question you have is valid and I actually am not aware which timezone they are sending notifications in. In all of our notifications previously received, it is never stated which timezone they are sending these notifications in. I will follow up with their support team and get that answer.
I'll also fix up those two little things! :) Thanks! |
|
Hi @jvanderaa - please take another look when you get the chance! I spoke with KPN and they responded with the following:
I copied parts of summitig and this should now be resolved so everything should be covered. Let me know if theres anything else missing! |
Resolves #432
Added the relevant changes in order to introduce KPN as a provider to the CMP library.
All tests pass.
Only have a XLSX parser available as this is their method to notifications. Email body doesn't contain any useful information.
They do attach a PDF, but PDF parsers are not super supported yet.
Some Dutch in their emails to be aware of.