Skip to content
This repository was archived by the owner on Oct 29, 2020. It is now read-only.
This repository was archived by the owner on Oct 29, 2020. It is now read-only.

Correct p-value estimation for unbiased Dcorr, and other edits to abstract p_value #177

Description

@rmehta004

For unbiased DCorr, a t-distribution approximation is used to estimate the p-value. MGC, unbiased DCorr, and biased DCorr should have a simple permutation test to estimate each of their p-values.

The proposal here is to not only remove the t approximation, but to have the abstract p-value only be a simple permutation test, and let it be inherited by MGC, unbiased DCorr, and biased DCorr. For other tests, their methods can override the inherited p-value.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions