Skip to content

Add missing underline style apply in _sfte_csi_exec_sgr #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nihiL7331 merged 2 commits into from
Sep 20, 2026
Merged

Add missing underline style apply in _sfte_csi_exec_sgr #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d754011
fix: apply the underline style in parser on 4:x SGR
nihiL7331 Sep 20, 2026
a6de161
chore: bump version to v1.01
nihiL7331 Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sfte_dev.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
sfte -- single-file terminal emulator
v1.00
v1.01

Project URL: https://github.com/nihiL7331/sfte

Expand Down Expand Up @@ -5549,7 +5549,12 @@ static inline void _sfte_csi_exec_sgr(sfte_ctx *ctx, uint16_t *p, uint16_t cnt)
case 3: ctx->term.cur_attr |= _SFTE_ATTR_ITALIC; break;
case 4: ctx->term.cur_attr |= _SFTE_ATTR_UNDERLINE;
#if SFTE_UNDERLINE_EXTENDED
// Default to straight if no sub-param is provided
ctx->term.cur_ul_style = _SFTE_UNDERLINE_STYLE_STRAIGHT;

// If the sub-param exists and defines a style set it
if (i + 1 < cnt && p[i + 1] <= _SFTE_UNDERLINE_STYLE_DASHED)
ctx->term.cur_ul_style = p[++i];
#endif // SFTE_UNDERLINE_EXTENDED
break;
case 7: ctx->term.cur_attr |= _SFTE_ATTR_REVERSE; break;
Expand Down
Loading