Repository navigation
Scrollback search feature - #89
Merged
Merged
Conversation
missing update from last fix
if a shortcut function returns 1, it means it should consume the input. return 0, if the shortcut keys should be passed further. this is necessary for proper binding for search bar
its an RGB888 value, not ARGB8888.
They're handled using `_SFTE_ENSURE_DEPS`.
requires refactoring cursor rendering which is included in this commit.
…`_sfte_render_cursor`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #83.
This PR implements searching through the scrollback buffer using regex.
Hidden behind
SFTE_SEARCHwith multiple configuration options (mostly visual stuff + buffer sizes).It uses
regex.hfor POSIX implementations, andtiny-regex-cifSFTE_NO_POSIXis defined.Shortcuts used to control searching are:
There were some changes to the general codebase alongside that:
1means that the input for that shortcut should be consumed,0if it should not.v1.xxversioning with SemVerv1.x.yversioning.argb_colortorgb_colorinSFTE_COLOR_BLEND_PIXEL(since it's RGB888 and not ARGB8888).#ifs in codebase, since dependency checks are handled by_SFTE_ENSURE_DEPSnow.sfte_parseand_sfte_grid_dirty_trail.