Skip to content

fix: hint the R ns-resources key in the namespaces header - #960

Merged
nklmilojevic merged 1 commit into
mainfrom
fix/namespaces-hint-ns-resources
Oct 22, 2026
Merged

nklmilojevic merged 1 commit into
mainfrom
fix/namespaces-hint-ns-resources

Conversation

@nklmilojevic

Copy link
Copy Markdown
Owner

Summary

R on a namespace row opens :ns-resources (#901). It is listed in docs/keys.md and the ? help, but it was missing from the namespaces header hints. This adds it to the second hint line as R resources. The label is taken from the keymap, so a rebound key is shown correctly.

Testing

  • New namespace_rows_hint_the_ns_resources_key test checks that the namespaces header hints include R resources.
  • just check passes.

Closes #953

The :ns-resources view (#901) bound R on namespace rows and documented it
in docs/keys.md and the ? help, but the per-kind header hints for
namespaces were never updated, so the key was undiscoverable from the
view itself even though the second hint line had room for it.

Closes #953
@kritikal-github

Copy link
Copy Markdown

Re-runKritika Review

Adds the namespace resources shortcut to header hints.

No findings

Confidence 5/5 · low risk: The change only adds a header hint and a test; the review checked the key binding and available header space.

Summary

The namespaces header now shows the key bound to the resources action alongside edit and delete. The new hint uses the existing keymap-aware rendering path, and the test covers the default binding.

What's good

  • Uses hint_line to derive the displayed key from the active keymap.
  • Places the hint in the existing third column without changing header width.
Review context · 0/6 commands
  • Commands run: none

Reviews (1) · Last reviewed commit: "fix: hint the R ns-resources key in the..." · gpt-6-sol

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds the resources shortcut to the namespaces header.

  • Namespace headers show the key for opening their resources.

Reviews (1) · Last reviewed commit: "fix: hint the R ns-resources key in the ..." · Reviewed by Greptile

@nklmilojevic
nklmilojevic merged commit 487b385 into main Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: R key not shown in Namespaces view

1 participant