Skip to content

chore: Strip basis tokens page to prepare for new setup - #1006

Merged
bartveneman merged 10 commits into
mainfrom
strip-basis-tokens-page
Sep 14, 2026
Merged

bartveneman merged 10 commits into
mainfrom
strip-basis-tokens-page

Conversation

@bartveneman

@bartveneman bartveneman commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor
  • verwijder template previews (incl. browser-window en scraper-related dingetjes)
  • verwijder sidebar met color-scale-inputs en font-inputs en bijbehorende event handling in the wizard-app
  • verplaats de tests voor download/reset buttons naar de publish-tokens.spec.ts
  • verwijder style-dictionary uit theme-wizard-app en maak genereren van legacy tokens en CSS output een stuk simpeler

@bartveneman
bartveneman requested a review from a team as a code owner September 11, 2026 13:08
@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clippy-storybook Ready Ready Preview Sep 14, 2026 9:12am UTC
theme-wizard Ready Ready Preview Sep 14, 2026 9:12am UTC
theme-wizard-server Ready Ready Preview Sep 14, 2026 9:12am UTC

Request Review

@codecov-commenter

codecov-commenter commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (fad3537) to head (a5deb2e).
⚠️ Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
packages/theme-wizard-app/src/lib/Theme/lib.ts 41.66% 5 Missing and 2 partials ⚠️
packages/theme-wizard-app/src/lib/Theme/index.ts 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   85.83%   90.69%   +4.86%     
==========================================
  Files          79      109      +30     
  Lines        2408     3301     +893     
  Branches      539      804     +265     
==========================================
+ Hits         2067     2994     +927     
+ Misses        282      262      -20     
+ Partials       59       45      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

Comment thread packages/theme-wizard-app/src/lib/Theme/index.ts
Comment thread packages/theme-wizard-app/src/lib/Theme/index.ts
Comment thread packages/theme-wizard-app/src/utils/story-token-matches.ts
@bartveneman
bartveneman merged commit b8b3f06 into main Sep 14, 2026
13 checks passed
@bartveneman
bartveneman deleted the strip-basis-tokens-page branch September 14, 2026 14:56

This branch was successfully deployed

3 active deployments
Preview – theme-wizard-server — a5deb2e8 Deployed Sep 14, 2026 by vercel[bot]
Preview – theme-wizard — a5deb2e8 Deployed Sep 14, 2026 by vercel[bot]
Preview – clippy-storybook — a5deb2e8 Deployed Sep 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants