deps: c-ares: cherry-pick 8ba37af8e3fb#64110
Open
Renegade334 wants to merge 1 commit into
Open
Conversation
Original commit message:
Fixes nodejs#1056
The commit
c-ares/c-ares@1d1b3d4
refactored the function to use wide strings, but didn't touch this
check. Because an empty wide string would now be size 2 and not 1, the
empty string would go on and cause the DNS domain list to be replaced
with nothing.
Signed-off-by: @dankmeme01
Refs: c-ares/c-ares@8ba37af
Collaborator
|
Review requested:
|
nodejs-github-bot
added
cares
Renegade334
added
lts-watch-v22.x
lpinca
approved these changes
Jun 24, 2026
Renegade334
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
approved these changes
Jun 25, 2026
cjihrig
approved these changes
Jun 25, 2026
aduh95
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the OS's DNS servers list being ignored on Windows since #60997. This patch landed in c-ares in February, but with no sign of an imminent release, it's probably worth cherry-picking this; the impact is fairly significant.
Fixes: #62347