Repository navigation
fix: make invalid session errors clearer - #22
Merged
g-linville merged 1 commit intoOct 9, 2026
Merged
Conversation
Signed-off-by: Grant Linville <grant@obot.ai>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Changes recommended
Obot currently attempts to JSON-decode the new plain-text 401 response, reproducing the reported parsing error instead of clearing the session.
1 open finding
What changed in this PR
Introduces explicit invalid-session handling for authentication refresh failures related to obot#8164.
Changes:
- Classifies rejected refreshes as invalid sessions.
- Returns HTTP 401 for invalid sessions.
- Adds status-mapping tests.
| File | Description |
|---|---|
github-auth-provider/main.go |
Uses shared state-error handling. |
auth-providers-common/pkg/state/state.go |
Adds invalid-session classification and HTTP mapping. |
auth-providers-common/pkg/state/state_test.go |
Tests error-to-status mapping. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
calvinmclean
approved these changes
Oct 8, 2026
njhale
approved these changes
Oct 8, 2026
thedadams
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this solves part of obot-platform/obot#8164
Once this is merged, I will have a PR for enterprise-providers to bump their dependencies on this, and then the actual fix in Obot that relies on this.