Skip to content

feat(o11y): bring stdout/nop outputs fully into the self-telemetry spine (PIPE-1066) - #290

Open
Dylan-M wants to merge 1 commit into
graphite-base/290from
dylanmyers/pipe-1066-stdout-nop-spine
Open

feat(o11y): bring stdout/nop outputs fully into the self-telemetry spine (PIPE-1066)#290
Dylan-M wants to merge 1 commit into
graphite-base/290from
dylanmyers/pipe-1066-stdout-nop-spine

Conversation

@Dylan-M

@Dylan-M Dylan-M commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Proposed Change

Pulls the last two outputs into the spine. stdout and nop now take a TelemetrySettings,
build per-instance metrics, and share the bridged logger like every other output. stdout
gets a gated blitz.output.stdout.flush span around the real I/O. nop gets a
records-written counter but no span, since it is a synchronous no-op already inside the
emit span. The counter lets a load run measure how many records a nop output absorbed.

How to validate

  • Run stdout with per-batch spans on, pointing at a collector:
    go run ./cmd/blitz --generator-type apache-common --generator-apache-common-rate 1s --output-type stdout --metrics-port 9100 --telemetry-traces-otlpendpoint localhost:4317 --telemetry-traces-insecure --telemetry-traces-perbatchspans
  • Confirm stdout's self-metrics (curl -s localhost:9100/metrics | grep blitz_output_) and
    a blitz.output.stdout.flush span at the collector.
  • Change --output-type nop and confirm its records-written counter climbs:
    curl -s localhost:9100/metrics | grep blitz_output_entries_received.
  • go test ./output/nop/... ./output/stdout/... covers metrics, the flush span, and the
    nop counter.
Checklist
  • Changes are tested
  • CI has passed

@Dylan-M
Dylan-M force-pushed the dylanmyers/pipe-1066-output-send-spans branch from dbf7635 to f12b841 Compare September 4, 2026 21:00
@Dylan-M
Dylan-M force-pushed the dylanmyers/pipe-1066-stdout-nop-spine branch from b0b8845 to ddcf75e Compare September 4, 2026 21:00
…ine (PIPE-1066)

Assisted-by: Claude Opus 4.8
@Dylan-M
Dylan-M force-pushed the dylanmyers/pipe-1066-stdout-nop-spine branch from ddcf75e to 744af77 Compare September 4, 2026 22:54
@Dylan-M
Dylan-M force-pushed the dylanmyers/pipe-1066-output-send-spans branch from f12b841 to a6a38d6 Compare September 4, 2026 22:54
@graphite-app
graphite-app Bot changed the base branch from dylanmyers/pipe-1066-output-send-spans to graphite-base/290 September 4, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants