Skip to content

chore(ci): run the full suite on merge_group and regenerate completions - #310

Merged
Dylan-M merged 3 commits into
mainfrom
dylanmyers/fix-completion-ci-merge-queue
Sep 10, 2026
Merged

chore(ci): run the full suite on merge_group and regenerate completions#310
Dylan-M merged 3 commits into
mainfrom
dylanmyers/fix-completion-ci-merge-queue

Conversation

@Dylan-M

@Dylan-M Dylan-M commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Proposed Change

When the blitz library subcommands landed, package/completions/blitz.bash was never regenerated, so it is missing every blitz library * completion. The completion check catches this on pull requests. But it, like the other generated-artifact checks, is gated only on the Graphite CI optimizer, so the merge queue merged the drift without running it.

This PR:

  • Regenerates blitz.bash to match the current command tree.
  • Adds a detect-changes job (mirroring bindplane-op-enterprise) whose outputs default to true on merge_group and push. Jobs gate on it alongside the optimizer, so pull requests skip irrelevant-path jobs. The merge queue and post-merge run the full suite.

Validation:

  • make completion-check passes with the regenerated blitz.bash.
  • The Shell completion check is green on this PR.
Checklist
  • Changes are tested
  • CI has passed

@Dylan-M
Dylan-M requested review from a team as code owners September 4, 2026 22:08

Dylan-M commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dylan-M Dylan-M changed the title chore: regenerate blitz completions for the library subcommands chore(ci): run the full suite on merge_group and regenerate completions Sep 4, 2026
@Dylan-M
Dylan-M requested a review from eKuG September 4, 2026 22:08
@Dylan-M
Dylan-M force-pushed the dylanmyers/fix-completion-ci-merge-queue branch from d060641 to dc6d1f8 Compare September 10, 2026 14:19
@Dylan-M
Dylan-M added this pull request to the merge queue Sep 10, 2026
Merged via the queue into main with commit 0276109 Sep 10, 2026
20 checks passed
@Dylan-M
Dylan-M deleted the dylanmyers/fix-completion-ci-merge-queue branch September 10, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants