Repository navigation
fix(autostore): preserve default and explicit per-item modes - #633
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New players now retain the default all-item mode when their saved settings are empty. Persist an explicit all-mode flag so disabling all-item mode with no selected items survives saving, reloading, and export.
Addresses F07. Regression tests cover new-player defaults, empty per-item settings, export, and selected-item reloads.
Legacy empty-data decision:
CustomDataManager.loadDatareturns an empty node for both missing data and a persisted empty node. Earlier serializers used that same representation for disabled per-item mode with no selected items. YAML and SQLite delete empty custom data when saving, so checking persisted keys cannot recover the original mode either. Empty data intentionally uses the new disabled/all-item defaults. It stays disabled, but enabling it later affects all items. This PR records the decision; to retain disabled per-item mode, run/box autostore item all offfollowed by/box autostore off. A regression test covers a persisted legacy empty node; new saves persistall-modeexplicitly.Validation: the Java 25 Gradle build and tests passed in GitHub Actions. README has no changes relative to the base branch.