(fix) wrong queue delay calculation - #143
Open
pratham15541 wants to merge 1 commit into
Open
pratham15541 wants to merge 1 commit into
pratham15541 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Queue.enqueue()function is supposed to add a "run" (a task to be processed) to the queue. But in the old code, after adding the run, it does not record the time when the run was added, and it does not send an event to say "a run was added to the queue." This is different from theenqueueBlocking()function, which does both.Because of this, when the system later tries to calculate how long a run waited in the queue, it might use a zero or missing time, which makes the wait time metrics wrong.
To fix this, enqueue() should:
runCtx.RunInfo.QueueTime = time.Now()QueueEventTypeQueueAddedpriorityparameter for the event priorityFixes: #142