Restore backend image release publishing - #147
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 41.29% 41.29%
=======================================
Files 25 25
Lines 6868 6868
=======================================
Hits 2836 2836
Misses 3770 3770
Partials 262 262 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore release workflow publishing for the backend Docker image.
This makes future releases publish:
omegaup/backend:${VERSION}omegaup/backend:sha-${REVISION}ghcr.io/omegaup/backend:${VERSION}ghcr.io/omegaup/backend:sha-${REVISION}It also updates
docker/Dockerfile.backendfromubuntu:focaltoubuntu:22.04and OpenJDK 17, so the image can run backend binaries built by the current Ubuntu 22.04 release workflow.Why
v1.9.73successfully published the GitHub release assetomegaup-backend.tar.xz, but did not publishdocker.io/omegaup/backend:v1.9.73.Production consumes
omegaup/backend:${VERSION}, so the prod bump hitImagePullBackOff.A manual backend image build also exposed that the old
ubuntu:focalbase image cannot run the current release binaries because they require newer GLIBC versions.Validation
.github/workflows/release.ymlas YAML.git diff --check.docker build --pull \ --build-arg RELEASE=v1.9.73 \ -f docker/Dockerfile.backend \ -t quark-backend-test:v1.9.73 \ dockerdocker run --rm --platform linux/amd64 quark-backend-test:v1.9.73 /usr/bin/omegaup-grader -version docker run --rm --platform linux/amd64 quark-backend-test:v1.9.73 /usr/bin/omegaup-broadcaster -version docker image inspect quark-backend-test:v1.9.73 --format '{{.Architecture}}'Results: