QNN EP: Add MaxPool and AveragePool tier-based tests - #879
Draft
yuhuchua-qti wants to merge 3 commits into
Draft
yuhuchua-qti wants to merge 3 commits into
yuhuchua-qti wants to merge 3 commits into
Conversation
yuhuchua-qti
requested review from
minfhong-qti,
qti-ashwshan,
qti-chuteng,
qti-shubham,
qti-yuduo and
tirupath-qti
as code owners
September 29, 2026 02:10
yuhuchua-qti
marked this pull request as draft
September 29, 2026 02:58
yuhuchua-qti
force-pushed
the
dev/yuhuchua/qnn-maxpool-tier-migration
branch
from
September 30, 2026 01:56
981ce86 to
6d3c2fc
Compare
yuhuchua-qti
force-pushed
the
dev/yuhuchua/qnn-maxpool-tier-migration
branch
from
October 1, 2026 09:53
d75890d to
9024f90
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxPoollegacy coverage to tier-based tests with a 1:1 mapping.AveragePooland 2GlobalAveragePool.Test Structure
averagepool_specs.hprovides shared specs that distinguishAveragePoolandGlobalAveragePoolthroughop_type.pool_op_builder_test.cc: invalidauto_pad, non-unit dilations, rank-2 inputs, and multiple outputs.maxpool_test.ccretains the MaxPool-specific HTP rank-5 rejection.Validation
python qcom/build_and_test.py lint --target-py-version 3.12python qcom/build_and_test.py test --target-py-version 3.12pool_op_builder.cc: 100% line coverage and 52.64% branch coverage.Follow-up
ceil_modecase is currently mapped for AveragePool; retain it as a session-level follow-up.