fix: name the storage delete hooks as the core declares them - #202
Open
benjaminbruun wants to merge 1 commit into
Open
benjaminbruun wants to merge 1 commit into
benjaminbruun wants to merge 1 commit into
Conversation
Contributor
Firmware footprint delta —
|
| Memory | base | PR | Δ |
|---|---|---|---|
| Flash | 146.1 KiB | 146.2 KiB | +96 B |
| RAM | 72.3 KiB | 72.3 KiB | +0 B |
Section size changes (from the section headers)
+54 B .strtab (65698 -> 65752)
+144 B .symtab (82080 -> 82224)
+88 B text (111776 -> 111864)
Top symbol changes (10 largest, from the symbol tables)
+72 B ss_delete_file
+8 B nvs_delete
+4 B ss_delete_dir
+4 B ss_create_dir
Soft report — informational only. Base 418e66207ab626f4a312fdcf6d5656eb97d5c712 vs PR head.
benjaminbruun
marked this pull request as ready for review
September 2, 2026 07:00
ss_remove/ss_rmdir/ss_mkdir were never called: the weak ss_delete_file/ ss_delete_dir/ss_create_dir they stood in for stayed undefined, so DELETE FILE reported success and deleted nothing. Signed-off-by: Benjamin Bruun <bb@onomondo.com>
benjaminbruun
force-pushed
the
fix/storage-delete-hooks
branch
from
September 2, 2026 07:00
e55c9ea to
d1cfb8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port defined its delete and create-dir hooks as
ss_remove/ss_rmdir/ss_mkdir, names nothing calls, so the core's weakss_delete_file/ss_delete_dir/ss_create_dirstayed undefined; on the nRF91 the linker turns those calls intonop.wand DELETE FILE answered 9000 having deleted nothing (on native_sim it is a NULL call). This renames the three functions to the declared names, no logic change, and adds two tests/fs cases covering delete of a middle and of a buffered last entry, the not-found path, flush-after-delete and remount. No exposure with the shipped template: its EF.ARR grants no DELETE FILE access, so the command is refused with 6982 before storage is reached. The test bodies are black-box and also pass on #197's swap-with-last rewrite; removing either its slot re-point or its hole-closing copy makes them fail (checked: 13/14 in both cases, only the new test fails). Footprint: rename only; nrf9151dk/ns app image 150,124 B flash / 74,040 B RAM, the delta versus master is the three restored branch instructions.