Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (94.87%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1227 +/- ##
==========================================
+ Coverage 92.42% 94.87% +2.44%
==========================================
Files 86 58 -28
Lines 8599 5231 -3368
Branches 509 212 -297
==========================================
- Hits 7948 4963 -2985
+ Misses 541 237 -304
+ Partials 110 31 -79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…cated_json_encoders
…cated_json_encoders
hellais
left a comment
There was a problem hiding this comment.
I think we should add a few more tests for this specific use-case. I am also seeing that some of the existing tests are failing and it's unclear if some downstream consumers might break as a result of this.
One thing we should be extra careful of is that only one serializer can be defined per field, so I'm not sure if by defining a catch all field serialiser this might impact how subclasses of this base class which use serialisers work.
Some additional tests and validation for that could help address this concern as well.
|
Added regression tests to confirm that this PR does break backwards compatibility, and then fixed the regression. |
|
There may be some additional endpoints that need tests to ensure no other regressions exist. |
adds regression tests to validate API responses stay backwards compatible to ooniauth, oonifindings, and oonirun services
|
On this branch I rebased additional date format regression tests to verify that the services ooniauth, oonifindings, and oonirun were not affected by this change |
Fixes deprecation warning about json_encoders