feat(footer): improve footer layout with additional content and styling - #55
Conversation
|
Warning Some commit messages in this PR do not follow the Conventional Commits specification. Expected format: 📋 Invalid commit messages
Tip Valid types: Note This is just a friendly reminder and will not block the PR from being merged. |
|
Note Linting checks passed successfully 🎉 All formatting and code quality checks are clean. You're good to merge 🚀 |
calebephrem
left a comment
There was a problem hiding this comment.
Amazing work!
But under the HIGHLIGHTS section we're being kind of repetitive, because we already have /pages/getting-started, /resources and /partners linked in the NAVIGATE section.
There is also a mistake: /partners is not open source contribution page
So, maybe instead make the links (and the labels) point to pages:
/pages/privacy-policy/pages/security-notice/pages/code-of-conductand/pages/acknowledgements
In order ;]
|
@calebephrem sure i will update the changes asked. |
|
Yessur. |
Summary by BeetleThis PR enhances the website footer component by significantly improving its layout and content structure. The changes transform the footer from a simple icon-based social links section into a more comprehensive footer with highlighted content sections, better visual organization, and improved user engagement. The footer now features a 4-column grid layout (instead of 3), adds a new "Highlights" section with curated links to important pages (Privacy Policy, Security Notice, Code of Conduct, and Acknowledgements), and redesigns the community social links from compact icon buttons to more accessible text-labeled links with better hover states. 📁 File Changes Summary (Consolidated across all commits):
Total Changes: 1 file changed, +183 additions, -59 deletions 🎯 Key Changes:
📊 Impact Assessment:
⚙️ SettingsSeverity Threshold: 📖 User Guide
|
| color: accent.indigoLightest, | ||
| }} | ||
| > | ||
| Highlights | ||
| </h4> | ||
| <ul className="space-y-3 mb-6"> | ||
| {highlightItems.map((item) => ( | ||
| <li key={item.label}> | ||
| <Link | ||
| href={item.href} | ||
| className="flex items-center gap-2 text-sm transition-colors hover:text-[#a5b4fc]" |
There was a problem hiding this comment.
The new Highlights section uses the Link component (line 264), but there's no visible import statement for it in the patch. If Link is not imported from next/link or another source, this will cause a runtime error.
Confidence: 4/5
Suggested Fix
Verify that Link is imported at the top of the file. If not present, add:
| color: accent.indigoLightest, | |
| }} | |
| > | |
| Highlights | |
| </h4> | |
| <ul className="space-y-3 mb-6"> | |
| {highlightItems.map((item) => ( | |
| <li key={item.label}> | |
| <Link | |
| href={item.href} | |
| className="flex items-center gap-2 text-sm transition-colors hover:text-[#a5b4fc]" | |
| import Link from "next/link"; | |
This import should be added to the imports section at the beginning of the file (typically near other React/Next.js imports).
Prompt for AI
Copy this prompt to your AI IDE to fix this issue locally:
In components/site/Footer.tsx, the new Highlights section uses the Link component
starting at line 264, but the import statement for Link from "next/link" may be missing.
Add the import statement at the top of the file if it's not already present:
import Link from "next/link";
📍 This suggestion applies to lines 264-274
|
Note Linting checks passed successfully 🎉 All formatting and code quality checks are clean. You're good to merge 🚀 |
|
@Shamanth-Kumar-K thank you for contributing! |
|
@calebephrem Thanks for the Opportunity 😊 |
|
Thank you as well! |
Description
This pull request improves the footer section by making better use of the previously empty space.
Changes made
Testing
Image of the Output