[CONFIGURATION] Add composable sampler extensions - #4415
Merged
dbarker merged 3 commits intoAug 12, 2026
Conversation
shixi-li
marked this pull request as draft
August 11, 2026 18:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4415 +/- ##
==========================================
+ Coverage 82.65% 82.69% +0.05%
==========================================
Files 503 505 +2
Lines 19904 19933 +29
==========================================
+ Hits 16449 16482 +33
+ Misses 3455 3451 -4
🚀 New features to boost your workflow:
|
Contributor
Author
|
/easycla |
marcalff
approved these changes
Aug 12, 2026
marcalff
left a comment
Member
There was a problem hiding this comment.
LGTM
Excellent work, fits perfectly into the existing design pattern.
dbarker
approved these changes
Aug 12, 2026
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! Adding a custom composable sampler example in examples/configuration would be a great followup PR to show others how to use this new extension point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4409
Changes
Testing
cmake --build build --target registry_test yaml_trace_test sdk_builder_test -j4registry_test,yaml_trace_test, andsdk_builder_test(125 tests passed)clang-format --dry-run --Werroron the changed C++ filesFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes