[CONFIGURATION] Add builders for the container and process resource detectors - #4417
Merged
dbarker merged 5 commits intoAug 12, 2026
Merged
Conversation
…etectors Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
Linking configuration_core pulls in sdk_builder.cc, which requires exception support, so the new builder tests move to a separate test target that the noexcept build skips, like sdk/test/configuration. Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4417 +/- ##
==========================================
- Coverage 82.69% 82.58% -0.11%
==========================================
Files 505 509 +4
Lines 19933 19972 +39
==========================================
+ Hits 16482 16492 +10
- Misses 3451 3480 +29
🚀 New features to boost your workflow:
|
Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
dbarker
reviewed
Aug 12, 2026
dbarker
left a comment
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks for the feature! Please see feedback and a change request to the CMake configuration below.
Per review: the builders target joins the existing resource_detectors component instead of shipping as its own, renamed to opentelemetry_resource_detectors_builders, and its install test cases merge into the component's existing test file. Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
marcalff
approved these changes
Aug 12, 2026
marcalff
left a comment
marcalff
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the feature.
…builders # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4412
Changes
Adds configuration builders for the two existing resource detectors,
ContainerDetectorBuilderandProcessDetectorBuilder, inresource_detectors/, following theConsoleSpanBuilderpattern. Both are registered inexamples/configuration/main.ccbehind a newOTEL_HAVE_RESOURCE_DETECTORSdefine, since that example also builds withoutWITH_RESOURCE_DETECTORS_PREVIEW.The builders ship as a new
resource_detectors_buildercomponent mirroring the exporter builder components, with the matching install component test and an entry in the cmake.install.test expected components list.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes