Skip to content

[Fix #1183] Enforce LiteralUri/LiteralUriTemplate distinction via regex - #1197

Merged
cdavernas merged 1 commit into
open-workflow-specification:mainfrom
ricardozanini:issue/1183
Oct 9, 2026
Merged

cdavernas merged 1 commit into
open-workflow-specification:mainfrom
ricardozanini:issue/1183

Conversation

@ricardozanini

Copy link
Copy Markdown
Collaborator

Fixes #1183.

The two anyOf branches in uriTemplate shared the same regex, making their distinction rely solely on format validation (which is optional in JSON Schema).

Changes:

  • LiteralUriTemplate pattern now requires at least one {var} pair
  • LiteralUri pattern now rejects any curly braces
  • format annotations kept as-is per maintainer agreement
  • Tests updated to reflect and enforce the new distinction

…emplate distinction via regex

- LiteralUriTemplate requires at least one {var} pair
- LiteralUri rejects any { or } characters
- Keep format annotations (uri-template, uri-reference) as-is
- Update tests accordingly

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 9, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ricardozanini
ricardozanini requested a lite review from Copilot October 9, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cdavernas cdavernas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas
cdavernas merged commit 44b3186 into open-workflow-specification:main Oct 9, 2026
4 checks passed
ricardozanini added a commit to ricardozanini/sw-specification that referenced this pull request Oct 9, 2026
…emplate distinction via regex (open-workflow-specification#1197)

- LiteralUriTemplate requires at least one {var} pair
- LiteralUri rejects any { or } characters
- Keep format annotations (uri-template, uri-reference) as-is
- Update tests accordingly

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LiteralUri and LiteralUriTemplate patterns are identical, distinction relies on optional format validation

3 participants