Skip to content

WEB-1098: Fix Home search missing modules and blank 404 entry #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Farah-Nahle-FOO wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −1
Open

WEB-1098: Fix Home search missing modules and blank 404 entry #3791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/home/activities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,12 @@ const activities: any[] = [
{ activity: 'create accounting closure', path: '' },
{ activity: 'navigation', path: '/navigation' },
{ activity: 'remittances', path: '/remittances/process' },
{ activity: '', path: 'home' }
{ activity: 'loans', path: '/loans' },
{ activity: 'collections', path: '/collections' },
{ activity: 'notifications', path: '/notifications' },
{ activity: 'profile', path: '/profile' },
{ activity: 'settings', path: '/settings' },
{ activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' }
Comment thread
IOhacker marked this conversation as resolved.

@coderabbitai coderabbitai Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Make “tasks” searchable as its own activity.

src/app/home/home.component.ts (Lines 66-133) and src/app/home/dashboard/dashboard.component.ts (Lines 40-84) only match activity names from the beginning. The label checker inbox and tasks does not match a search for tasks. Add separate checker inbox and tasks records, or update the shared filter to support token matching.

Based on the downstream filtering in src/app/home/home.component.ts (Lines 66-133) and src/app/home/dashboard/dashboard.component.ts (Lines 40-84), the activity label must match the search term.

Possible local fix 
-  { activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' }
+  { activity: 'checker inbox', path: '/checker-inbox-and-tasks' },
+  { activity: 'tasks', path: '/checker-inbox-and-tasks' }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{ activity: 'checker inbox and tasks', path: '/checker-inbox-and-tasks' }
{ activity: 'checker inbox', path: '/checker-inbox-and-tasks' },
{ activity: 'tasks', path: '/checker-inbox-and-tasks' }
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/home/activities.ts` at line 67, Update the activity definitions
around “checker inbox and tasks” so the existing filters in home and dashboard
can match “tasks” as an independent search term; preferably replace the combined
record with separate “checker inbox” and “tasks” records while preserving the
appropriate route behavior.

];

export { activities };
Loading