WEB-1101: Add missing translation keys for Disable/Enable Withhold Ta…

[Farah-Nahle-FOO]

Description

The "More" submenu on the savings account hamburger menu displayed the raw i18n key labels.menus.Disable Withhold Tax (and Enable Withhold Tax) instead of a readable label, because the menus translation namespace never had entries for these two menu actions. Added the missing Disable Withhold Tax and Enable Withhold Tax keys to src/assets/translations/en-US.json so ngx-translate resolves a proper label instead of falling back to the raw key. This also fixes the same menu action on the recurring deposit and fixed deposit account views, since they share the same translation keys. No new dependencies are required.

Related issues and discussion

WEB-1101

Before: menu item shows labels.menus.Disable Withhold Tax
After: menu item shows Disable Withhold Tax

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• New Features
  • Added English menu labels for enabling and disabling withholding tax.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "pre_merge_checks"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 971837a1-ca1d-4dab-86cc-0ee50284dafc

📥 Commits

Reviewing files that changed from the base of the PR and between e842bba and 5948717.

📒 Files selected for processing (1)

• src/assets/translations/en-US.json

🚧 Files skipped from review as they are similar to previous changes (1)

• src/assets/translations/en-US.json

---

Walkthrough

Changes

Withholding tax translations

Layer / File(s)	Summary
Add withholding tax menu labels src/assets/translations/en-US.json	Adds English labels for "Enable Withhold Tax" and "Disable Withhold Tax".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the addition of missing translation keys for enabling and disabling withholding tax.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.