fix(WEB-1100): use business date for client activation date picker an…

[Ruba-Tawk-FOO]

…d enable confirm on first selection

In the Client Approval flow, the activation-date picker did not allow selecting today's date on the first attempt (Confirm stayed disabled) and followed the browser date rather than the system business date.

• Default the picker value and max date to the system business date.
• Open the dialog non-pristine so the pre-filled date is immediately valid and Confirm is enabled on the first selection.

Description

Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • Client approval date selection now defaults to the configured business date.
  • Prevented users from selecting an approval date later than the business date.
  • Improved dialog state handling when approving clients.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "pre_merge_checks"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 25847397-a978-4ff9-9f60-2faf0fd56ef7

📥 Commits

Reviewing files that changed from the base of the PR and between f0bffd4 and 258b23a.

📒 Files selected for processing (1)

• src/app/tasks/checker-inbox-and-tasks-tabs/client-approval/client-approval.component.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/tasks/checker-inbox-and-tasks-tabs/client-approval/client-approval.component.ts

---

Walkthrough

The client approval dialog uses settingsService.businessDate, with the current date as fallback, for date picker initialization and limits. The dialog data sets pristine to false.

Changes

Client approval dialog

Layer / File(s)	Summary
Approval dialog date and state src/app/tasks/checker-inbox-and-tasks-tabs/client-approval/client-approval.component.ts	The date picker uses the business date for its initial value and maximum date. The dialog data sets pristine: false.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the client activation date picker update to use the business date.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/app/tasks/checker-inbox-and-tasks-tabs/client-approval/client-approval.component.ts`:
- Line 171: Update the dialog configuration containing label, title, and
layout.addButtonText to use the project’s `@ngx-translate/core` translation
variables instead of hardcoded English strings. Add and extract translation keys
for any new user-facing text, preserving the existing dialog behavior and
structure.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e8b828f1-c4fc-4474-abf0-ed0e662cad30

📥 Commits

Reviewing files that changed from the base of the PR and between ae1cadc and f0bffd4.

📒 Files selected for processing (1)

• src/app/tasks/checker-inbox-and-tasks-tabs/client-approval/client-approval.component.ts