WEB-1103: Allow future dates for Incorporation Validity Till Date

[Farah-Nahle-FOO]

Description

The Incorporation Validity Till Date field for Entity clients had a [max]="maxDate" binding on its datepicker that capped selectable dates at today's business date, blocking any future expiry date. Since this field represents the validity/expiry date of a company's incorporation documents, future dates are valid and expected.

Removed the max cap and changed [min] from the generic minDate to the entity's Incorporation Date value — which Fineract stores in the dateOfBirth form control for Entity legal form clients — falling back to minDate when it isn't set yet. This ensures the validity date can't be set before the incorporation date, while still allowing future expiry dates.

Applied to both the client creation stepper (client-general-step.component.html) and the edit-client form (edit-client.component.html), matching the equivalent fix already merged in mifosx-community-app. No new dependencies required.

Related issues and discussion

WEB-1103

Screenshots, if any

Checklist

• If you have multiple commits please combine them into one commit by squashing them.
• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • Updated incorporation validity date selection to prevent dates earlier than the client’s date of birth.
  • Removed the previous maximum-date restriction, allowing valid future dates to be selected.

[coderabbitai]

Warning

Review limit reached

@Farah-Nahle-FOO, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c28c98d-a25a-45e0-810a-b4d97bb6220e

📥 Commits

Reviewing files that changed from the base of the PR and between e842bba and ae08573.

📒 Files selected for processing (2)

• src/app/clients/client-stepper/client-general-step/client-general-step.component.html
• src/app/clients/edit-client/edit-client.component.html

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "pre_merge_checks"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The incorporation validity date fields now use the client’s date of birth as the minimum when available. The previous maximum-date constraint was removed from both client forms.

Changes

Incorporation date validation

Layer / File(s)	Summary
Update incorporation date constraints src/app/clients/client-stepper/client-general-step/client-general-step.component.html, src/app/clients/edit-client/edit-client.component.html	Both forms use dateOfBirth as the minimum date when set, with minDate as the fallback. Both forms remove the maxDate constraint.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: cocoa-puffs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: allowing future dates for the Incorporation Validity Till Date field.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}