WEB-1104: Hide Close action for already-closed clients

[Farah-Nahle-FOO]

Description

Hid the Close action from the client Header Actions menu once a client's status is already Closed. Previously the menu item was rendered unconditionally, so it stayed visible after closure; clicking it opened the Close form and submission then failed with a server-side "client is already closed" error. The fix gates the button on clientViewData.status.value === 'Active', mirroring the existing pattern already used for Reactivate/Activate/Reject in the same menu. No new dependencies.

Related issues and discussion

WEB-1104

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • The “Close” action is now shown only for clients with an Active status.

[coderabbitai]

Warning

Review limit reached

@Farah-Nahle-FOO, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eefebb19-4af4-4404-aaa2-803149baff56

📥 Commits

Reviewing files that changed from the base of the PR and between e842bba and f4c1f5c.

📒 Files selected for processing (1)

• src/app/clients/clients-view/clients-view.component.html

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "pre_merge_checks"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The client view now displays the “Close” action only when clientViewData.status.value is Active. Its click behavior and label remain unchanged.

Changes

Client Close Action

Layer / File(s)	Summary
Active status visibility src/app/clients/clients-view/clients-view.component.html	The Close action is wrapped in an @if condition that checks for Active status.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: alberto-art3ch

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: hiding the Close action for clients that are already closed.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}