fix: reject empty special token strings - #586
Open
chavalasantosh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject empty special-token strings when constructing
CoreBPE.An empty special token produces a zero-width match. If that token is allowed
while encoding non-empty text, the match does not advance the encoding cursor,
so the operation does not complete. The configuration currently constructs
without an error.
Changes
CoreBPE::new_internal.ValueErrorthrough the existing Python constructor wrapper.Validation
cargo test --lib— 3 passedpytest tests -q— 34 passedcargo fmt --check— passedgit diff --check— passedDisclosure
I used AI assistance during investigation and implementation. I reproduced the
behavior, reviewed the complete change, ran the validation above, and take
responsibility for the contribution.