Repository navigation
Pb/selectively diclosable claims - #804
paulbastian wants to merge 3 commits into
Conversation
|
|
||
| ISO/IEC 18013-5:2021 [@ISO.18013-5] defines a mobile driving license (mDL) Credential in the mobile document (mdoc) format. Although ISO/IEC 18013-5:2021 [@ISO.18013-5] is specific to mobile driving licenses (mDLs), the Credential format can be utilized with any type of Credential (or mdoc document types). The ISO/IEC 23220 series has extracted components from ISO/IEC 18013-5:2021 [@ISO.18013-5] that are common across document types to facilitate the profiling of the specification for other document types. The core data structures are shared between ISO/IEC 18013-5:2021 [@ISO.18013-5], ISO/IEC 23220-2 [@ISO.23220-2], ISO/IEC 23220-4 [@ISO.23220-4] which are encoded in CBOR and secured using COSE_Sign1. | ||
|
|
||
| Every data element in an mdoc, identified by its `NameSpace` and `DataElementIdentifier`, is a Selectively Disclosable Claim. This applies both to data elements returned in the `IssuerSigned` structure (i.e., in `IssuerNameSpaces`) and to data elements returned in the `DeviceSigned` structure (i.e., in `DeviceNameSpaces`) [@ISO.18013-5]. Consequently, the Wallet MUST NOT include any data element in either structure that has not been selected according to the rules in (#dcql_query_lang_processing_rules). |
There was a problem hiding this comment.
We should either update the examples using transaction data to implement this behavior, or allow an exception to this requirement for extensions like transaction data or other custom extensions.
There was a problem hiding this comment.
I think essentially something like this would work:
| Every data element in an mdoc, identified by its `NameSpace` and `DataElementIdentifier`, is a Selectively Disclosable Claim. This applies both to data elements returned in the `IssuerSigned` structure (i.e., in `IssuerNameSpaces`) and to data elements returned in the `DeviceSigned` structure (i.e., in `DeviceNameSpaces`) [@ISO.18013-5]. Consequently, the Wallet MUST NOT include any data element in either structure that has not been selected according to the rules in (#dcql_query_lang_processing_rules). | |
| Every data element in an mdoc, identified by its `NameSpace` and `DataElementIdentifier`, is a Selectively Disclosable Claim. This applies both to data elements returned in the `IssuerSigned` structure (i.e., in `IssuerNameSpaces`) and to data elements returned in the `DeviceSigned` structure (i.e., in `DeviceNameSpaces`) [@ISO.18013-5]. Consequently, the Wallet MUST NOT include any data element in either structure that has not been selected according to the rules in (#dcql_query_lang_processing_rules) or (#wherever_transaction_data_is_defined). |
There was a problem hiding this comment.
Discussed today: should add a brief addition excepting transaction data from the prohibition. @paulbastian will revise the PR.
There was a problem hiding this comment.
Actually as this is the mdoc section I think we should probably drop the MUST NOT here and include it (and the transaction data exception) in the generic section around line 936 instead. Possibly we need to be careful with the language to make sure it doesn't overrule the exception being added for age_over_xx claims in #800.
|
Discussed today: added reviewers, and @paulbastian will revise. |
GarethCOliver
left a comment
GarethCOliver
left a comment
There was a problem hiding this comment.
Approved after the changes to making transaction_data an exception
|
I think we should put this in the 1.0 errata too probably? |
This branch has not been deployed
5 participants
Closes #717