Repository navigation
Relax transaction data - #808
Open
GarethCOliver wants to merge 2 commits into
Open
GarethCOliver wants to merge 2 commits into
GarethCOliver wants to merge 2 commits into
Conversation
Instead of rejecting the whole request when any transaction_data object has an unrecognized/unsupported type or does not conform to its type definition, the Wallet treats the Credential Queries referenced by such an object as unsatisfiable and otherwise ignores it. The request only fails if the DCQL query can no longer be satisfied as a result. This allows a Verifier to offer alternative transaction data types (e.g. different versions, or ecosystem-specific types) in a single request, each bound to its own Credential Query, combined with credential_sets. - Move the normative rule out of the parameter definition into a new 'Processing Rules' subsection of the Transaction Data section - Add a cross-reference in the DCQL 'Selecting Credentials' rules - Scope the invalid_transaction_data error conditions accordingly - Align the mdoc KeyAuthorizations text with the new behaviour - Drop the single-credential MUST from the credential_ids definition - Add an illustrative example (transaction_data_alternatives.json) - Add Document History entry
Removed example from transaction_data handling clarification.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #794
This relaxes transaction data so that an 'unprocessable' transaction_data merely makes associated Credential Queries unsatisfiable rather than requiring the whole request to be failed.
As part of this, removed the weird MUST requirement of 'exactly one credential from credential ids' text, as Credential Queries are now (correctly) the way to enforce that.