Lost particle track files#3976
Open
viktormai wants to merge 7 commits into
Open
Conversation
paulromano
requested changes
Jul 1, 2026
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks @viktormai for taking a stab at this! I think this one is going to require a little more thought. One issue that I see is that when we re-run the particle in order to generate a track file, it also has undesirable side effects (e.g., contributing to tallies a second time). I'm not sure what the best way is to handle that but will think about it and let you know if I come up with anything.
In the meantime, it looks like your branch needs an update in order to pass tests. If you merge the current develop branch into yours and push, that should take care of the test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a particle is lost during transport, OpenMC now (with this PR) automatically replays it from its original source site with tracking enabled, writing the full track history to tracks.h5 without requiring a manual -r/-t restart. Previously, diagnosing a lost particle required identifying it from the warning output, then re-running with the restart file — this change eliminates that step entirely. If there are multiple lost particles, each is written to separate parts of one tracks.h5 file to avoid clogging up the directory.
This will also later support functionality in the plotter to help visualize particle failures in the geometry.
Checklist