feat(charges): add backend customer charge override clear - #4889
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (26)
📝 WalkthroughWalkthroughThe change adds customer charge override clearing for flat-fee and usage-based charges. It adds API and patch contracts, lifecycle states, reconciliation behavior, deletion timestamp preservation, and tests for active, deleted, invoice-backed, and subscription-synchronized charges. ChangesCustomer charge override clearing
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant CustomerChargeService
participant ChargeStateMachine
participant ChargeAdapter
participant Reconciliation
Client->>CustomerChargeService: ClearCustomerChargeOverride
CustomerChargeService->>ChargeStateMachine: Apply clear_override patch
ChargeStateMachine->>ChargeAdapter: Remove override layer
ChargeAdapter-->>ChargeStateMachine: Restored base intent
ChargeStateMachine->>Reconciliation: Reconcile realization and gathering state
Reconciliation-->>CustomerChargeService: Updated charge
CustomerChargeService-->>Client: Charge response
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
turip
force-pushed
the
feat/charges-set-override-backend-api
branch
2 times, most recently
from
August 9, 2026 11:14
0e3b6c8 to
fb06895
Compare
turip
force-pushed
the
feat/charges-clear-override-backend-api
branch
from
August 9, 2026 11:17
f7feac1 to
fb87881
Compare
turip
force-pushed
the
feat/charges-set-override-backend-api
branch
from
August 11, 2026 14:08
fb06895 to
49cbc32
Compare
turip
added
release-note/feature
turip
force-pushed
the
feat/charges-clear-override-backend-api
branch
from
August 12, 2026 08:56
cbfe885 to
9a0dee7
Compare
borosr
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Known follow-up
The generic charge ApplyPatches flow applies the first returned invoice-effect batch but does not yet explicitly resume lifecycle advancement afterward. Invoice-producing clears therefore still depend on the state-machine refactor follow-up before synchronous facade completion can be guaranteed.
Verification
Greptile Summary
The PR adds a customer charge override-clear facade that restores the latest base intent and reconciles flat-fee and usage-based lifecycle state.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD API[ClearCustomerChargeOverride] --> Patch[PatchClearOverride] Patch --> Apply[ApplyPatches] Apply --> Trigger[TriggerClearOverride] Trigger --> BaseDeleted{Base intent deleted?} BaseDeleted -->|No| ActiveClear[active.clear_override] BaseDeleted -->|Yes| DeletedClear[deleted.clear_override] ActiveClear --> ReconcileLive[Remove override and reconcile realization] ReconcileLive --> Destination{Restored timing and amount} Destination --> Created[created] Destination --> Active[active] Destination --> Final[final] DeletedClear --> ReconcileDeleted[Remove override and reconcile deletion] ReconcileDeleted --> Deleted[deleted]Reviews (4): Last reviewed commit: "fix(charges): align clear override revie..." | Re-trigger Greptile
Context used:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation