Skip to content

Fix multi-turn traces merging when prefix_caching differs in runtime_args (main) - #53

Draft
aas008 wants to merge 1 commit into
openshift-psap:mainfrom
aas008:fix/prefix-caching-from-runtime-args-main
Draft

Fix multi-turn traces merging when prefix_caching differs in runtime_args (main)#53
aas008 wants to merge 1 commit into
openshift-psap:mainfrom
aas008:fix/prefix-caching-from-runtime-args-main

Conversation

@aas008

@aas008 aas008 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Multi-turn benchmark data has prefix_caching = NaN even when runs differ in prefix caching config
  • The differentiating info is in runtime_args (e.g., no-enable-prefix-caching: True vs False)
  • This caused Performance Plots to merge distinct runs into a single zigzag trace

Fix

After existing prefix_caching fillna/astype preprocessing, backfill empty values from runtime_args:

  • no-enable-prefix-caching: Trueprefix_caching = "no" (caching OFF)
  • no-enable-prefix-caching: Falseprefix_caching = "yes" (caching ON)

Verification

Tested against staging CSV:

  • Before: All 17 multi-turn rows had prefix_caching = NaN
  • After: Rows correctly labeled "no" or "yes" based on runtime_args, producing separate trace keys

Test plan

  • Run ruff check dashboard.py — passes clean
  • Load dashboard and verify multi-turn traces no longer merge into zigzag lines
  • Verify single-turn rows (which already have prefix_caching set) are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved dashboard data handling by filling in missing prefix-caching status from available runtime settings.
    • Correctly identifies whether prefix caching is enabled or disabled when the status is not explicitly provided.

…args

Derive prefix_caching from runtime_args when the column is empty.
Multi-turn benchmark data has prefix_caching=NaN even though
no-enable-prefix-caching differs between runs, causing Performance
Plots to merge distinct runs into a single zigzag trace.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

load_data now fills empty prefix_caching values by parsing runtime_args for no-enable-prefix-caching: and mapping its boolean value to "no" or "yes".

Changes

Prefix caching data enrichment

Layer / File(s) Summary
Runtime argument backfill
dashboard.py
Adds parsing of no-enable-prefix-caching: tokens and applies the derived prefix-caching value only to rows with non-null runtime arguments and empty existing values.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main fix: preventing multi-turn trace merging by deriving prefix_caching from runtime_args.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aas008 aas008 changed the title Fix multi-turn traces merging when prefix_caching differs in runtime_args Fix multi-turn traces merging when prefix_caching differs in runtime_args (main) Jul 10, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@cf066be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dashboard.py 0.00% 10 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #53   +/-   ##
======================================
  Coverage        ?   3.46%           
======================================
  Files           ?       8           
  Lines           ?    8342           
  Branches        ?       0           
======================================
  Hits            ?     289           
  Misses          ?    8053           
  Partials        ?       0           
Flag Coverage Δ
unittests 3.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aas008
aas008 marked this pull request as draft August 3, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants