Fix multi-turn traces merging when prefix_caching differs in runtime_args (main) - #53
Conversation
…args Derive prefix_caching from runtime_args when the column is empty. Multi-turn benchmark data has prefix_caching=NaN even though no-enable-prefix-caching differs between runs, causing Performance Plots to merge distinct runs into a single zigzag trace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthrough
ChangesPrefix caching data enrichment
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
======================================
Coverage ? 3.46%
======================================
Files ? 8
Lines ? 8342
Branches ? 0
======================================
Hits ? 289
Misses ? 8053
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
prefix_caching = NaNeven when runs differ in prefix caching configruntime_args(e.g.,no-enable-prefix-caching: TruevsFalse)Fix
After existing
prefix_cachingfillna/astype preprocessing, backfill empty values fromruntime_args:no-enable-prefix-caching: True→prefix_caching = "no"(caching OFF)no-enable-prefix-caching: False→prefix_caching = "yes"(caching ON)Verification
Tested against staging CSV:
prefix_caching = NaN"no"or"yes"based onruntime_args, producing separate trace keysTest plan
ruff check dashboard.py— passes cleanprefix_cachingset) are unaffected🤖 Generated with Claude Code
Summary by CodeRabbit