AGENT-1493: Promote NoRegistryClusterInstall Feature to Default by sadasu · Pull Request #2859 · openshift/api

sadasu · 2026-05-26T15:53:55Z

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

openshift-ci-robot · 2026-05-26T15:54:01Z

@sadasu: This pull request references AGENT-1394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "5.0.0" version, but multiple target versions were set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-26T15:54:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 97471cf6-bed6-4fc6-be8d-6dacd518458d

📥 Commits

Reviewing files that changed from the base of the PR and between 230642e and 2db4418.

⛔ Files ignored due to path filters (6)

machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (9)

features.md
features/features.go
payload-manifests/crds/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

💤 Files with no reviewable changes (1)

payload-manifests/crds/0000_80_machine-config_01_internalreleaseimages-SelfManagedHA.crd.yaml

🚧 Files skipped from review as they are similar to previous changes (7)

features/features.go
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-Default.crd.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-OKD.crd.yaml
features.md
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-OKD.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-Default.crd.yaml

📝 Walkthrough

Walkthrough

This PR enables NoRegistryClusterInstall for Default and OKD profiles, updates its documentation and FeatureGate manifests, adds MachineConfigNode CRDs for SelfManagedHA Default and OKD, and removes selected annotations from related CRD manifests.

Suggested reviewers: joelspeed, davidesalerno

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: promoting NoRegistryClusterInstall to the default state.
Description check	✅ Passed	The description is directly related to the change and matches the feature promotion work.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The PR only changes a codegen analyzer; no Ginkgo It/Describe/Context/When titles were added or modified, so no unstable test names were introduced.
Test Structure And Quality	✅ Passed	No Ginkgo/cluster tests were added; the new unit tests use table-driven cases with clear assertions and no setup/cleanup/timeouts needed.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the new test file uses standard testing.T unit tests and no unsupported MicroShift APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the only change is in featuregate test analysis code, so SNO-specific test compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only docs, CRD annotations/schema, and feature-gate defaults changed; no pod affinity, nodeSelector, tolerations, replicas, or topology-aware scheduling logic was added.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes were added; changes are limited to feature-gate/manifest metadata, and features.go has no stdout/logging calls.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes feature-gate docs/manifests and feature-gate definitions; no new Ginkgo/e2e tests or network calls are added.
No-Weak-Crypto	✅ Passed	Diff only adds job-variant grouping/sorting; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret/token comparisons appear.
Container-Privileges	✅ Passed	The only changed file is a Go test-analyzer; it adds optional variants and contains no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The added stdout/output lines only print feature-gate names, job variants, counts, and test names; no secrets, PII, or internal hostnames were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-05-26T15:54:15Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-05-26T15:54:17Z

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2026-05-26T15:56:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-26T16:43:47Z

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2026-05-26T16:45:00Z

/jira refresh

openshift-ci-robot · 2026-05-26T16:45:04Z

@sadasu: This pull request references AGENT-1493 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

yuqi-zhang · 2026-05-26T21:31:04Z

    api-approved.openshift.io: https://github.com/openshift/api/pull/2510
    api.openshift.io/merged-by-featuregates: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
-    release.openshift.io/feature-set: CustomNoUpgrade,DevPreviewNoUpgrade,TechPreviewNoUpgrade


Looks like the IRI object itself is still v1alpha1 only: https://github.com/openshift/api/blob/master/machineconfiguration/v1alpha1/types_internalreleaseimage.go ?

We don't allow GA'ing with a alpha API. We would need to graduate the API to v1 first, before we graduate the dependent feature.

Do we require a separate PR for that?

@andfasano Yes, lets create a separate PR for that.

andfasano · 2026-06-04T12:06:11Z

Requires #2863

pawanpinjarkar · 2026-07-07T17:49:31Z

@sadasu the dependent PR #2880 is merged. Please rebase and fix the the conflicts.

JoelSpeed · 2026-07-13T09:05:57Z

Do we have any specific periodic tests that demonstrate this feature behaving as described?

andfasano · 2026-07-13T10:10:26Z

Do we have any specific periodic tests that demonstrate this feature behaving as described?

Yes, we added four different TP periodic jobs to cover all the supported platform type/network/topology combinations, here: https://sippy.dptools.openshift.org/sippy-ng/jobs/5.0?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522variants%2522%252C%2522operatorValue%2522%253A%2522has%2520entry%2522%252C%2522value%2522%253A%2522never-stable%2522%252C%2522not%2522%253Atrue%257D%252C%257B%2522id%2522%253A99%252C%2522columnField%2522%253A%2522name%2522%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522iso-no-registry%2522%257D%255D%257D&sort=asc&sortField=net_improvement.

Please note that the latest PR for bumping the IRI api to v1 successfully landed on Friday, but we didn't yet get a freshly updated green 5.0 nightly payload, thus the current stripe of failures.
Given that the daily presubmits jobs are fine, I'd expect to have again green periodics as soon as a new green nightly will be available (rebuilt with the latest available images)

JoelSpeed · 2026-07-13T12:19:06Z

Could we please add a mapping that maps the iso-no-registry style jobs to the NoRegistryClusterInstall featuregate please?

andfasano · 2026-07-13T14:12:48Z

Could we please add a mapping that maps the iso-no-registry style jobs to the NoRegistryClusterInstall featuregate please?

Recently we did some work with TRT to add the mapping in Sippy CR openshift-eng/ci-test-mapping#767. We've been able also to start gathering some data from the aforementioned jobs, this view seems to work right now

yuqi-zhang · 2026-07-13T22:55:33Z

Functionally speaking the code is fine. I think this is ready for merge once feature-promotion is green

sadasu · 2026-07-14T14:30:14Z

/test verify-feature-promotion

verify-feature-promotion test is not able to find the NoRegistryClusterInstall jobs.
Will retest after openshift/sippy#3772.

JoelSpeed · 2026-07-15T09:31:54Z

/test verify-feature-promotion

andfasano · 2026-07-15T09:49:38Z

It looks like at least now the tests are fetched

andfasano · 2026-07-17T10:17:21Z

The fix for the single failing test openshift/origin#31394 landed and it was included in https://amd64.ocp.releases.ci.openshift.org/releasestream/5.0.0-0.nightly/release/5.0.0-0.nightly-2026-07-17-034502, so the trend should improve from the next green nightly (they are still red). The latest two runs per job installed and verified the cluster correctly, they just failed as per #31394

andfasano · 2026-07-20T07:23:38Z

/test verify-feature-promotion

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Augment `verify-feature-promotion` output to indicate pass percentage for `install should succeed` tests for featuregates that include "Install" in their name. This update gives a better indication of whether Install features are failing at installation or later during execution of e2e conformance tests. This update does not change the criteria for reporting success but adds more information in the output for easier analysis of feature state.

Installer features now require a 100% pass rate for installation success and 80% pass rate for e2e test runs.

openshift-ci · 2026-07-20T21:42:46Z

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	`2db4418`	link	true	`/test verify-hypershift-integration`
ci/prow/verify-feature-promotion	`2db4418`	link	true	`/test verify-feature-promotion`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2026

openshift-ci Bot requested review from JoelSpeed and yuqi-zhang May 26, 2026 15:56

andfasano reviewed May 26, 2026

View reviewed changes

Comment thread features/features.go

sadasu changed the title ~~AGENT-1394: Promote NoRegistryClusterInstall Feature to Default~~ AGENT-1493: Promote NoRegistryClusterInstall Feature to Default May 26, 2026

yuqi-zhang reviewed May 26, 2026

View reviewed changes

andfasano mentioned this pull request Jun 9, 2026

AGENT-1522: Graduate InternalReleaseImage from v1alpha1 to v1 #2880

Merged

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2026

sadasu force-pushed the agent-iri-promotion branch from e5c1c9a to 230642e Compare July 10, 2026 17:16

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2026

sadasu mentioned this pull request Jul 14, 2026

Add NoRegistryClusterInstall capability to variant registry openshift/sippy#3772

Merged

sadasu added 4 commits July 20, 2026 12:04

AGENT-1493: Promote NoRegistryClusterInstall Feature to Default

63d3b4e

Feature NoRegistryClusterInstall is ready to be supported during Agent installs by default.

Updated feature promotion pass condition for Install features

e0321a0

Installer features now require a 100% pass rate for installation success and 80% pass rate for e2e test runs.

Always include metal single and compact variants as optional checks

2db4418

sadasu force-pushed the agent-iri-promotion branch from 230642e to 2db4418 Compare July 20, 2026 20:45

Uh oh!

Conversation

sadasu commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-merge-bot Bot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented May 26, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang May 26, 2026

Choose a reason for hiding this comment

Uh oh!

andfasano May 27, 2026

Choose a reason for hiding this comment

Uh oh!

sadasu May 27, 2026

Choose a reason for hiding this comment

Uh oh!

andfasano commented Jun 4, 2026

Uh oh!

pawanpinjarkar commented Jul 7, 2026

Uh oh!

JoelSpeed commented Jul 13, 2026

Uh oh!

andfasano commented Jul 13, 2026

Uh oh!

JoelSpeed commented Jul 13, 2026

Uh oh!

andfasano commented Jul 13, 2026

Uh oh!

yuqi-zhang commented Jul 13, 2026

Uh oh!

sadasu commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed commented Jul 15, 2026

Uh oh!

andfasano commented Jul 15, 2026

Uh oh!

andfasano commented Jul 17, 2026

Uh oh!

andfasano commented Jul 20, 2026

Uh oh!

openshift-ci Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented May 26, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented May 26, 2026 •

edited

Loading

openshift-ci-robot commented May 26, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented May 26, 2026 •

edited by openshift-ci Bot

Loading

sadasu commented Jul 14, 2026 •

edited

Loading