images: mirror netshoot for the ovn-kubernetes kubevirt e2e tests#31396
images: mirror netshoot for the ovn-kubernetes kubevirt e2e tests#31396qinqon wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test image whitelist was extended to allow ChangesImage Whitelist
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
|
Status update on the two pre-merge requirements:
|
|
/pipeline required |
|
Scheduling required tests: |
|
|
|
https://github.com/nicolaka/netshoot/blob/master/.github/workflows/release-buildx.yml#L49 shows this is released upstream with only linux/amd64,linux/arm64 . so openshift/release#82013 is acceptable |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jubittajohn, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
openshift/release#82013 must be merged first, and |
|
/retest-required |
openshift/origin#31396 adds ghcr.io/nicolaka/netshoot:v0.13 to the mirrored e2e image set (used by the ovn-kubernetes kubevirt e2e tests for the iperf test pods). The upstream image only publishes amd64 and arm64 manifests, so exempt it from the manifest list verification like the fedora-with-test-tooling containerdisk used by the same tests. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
|
/hold Please pin to a SHA rather than a tag for compliance |
openshift-ci
Bot
added
the
do-not-merge/hold
The ovn-kubernetes payload tests extension runs kubevirt e2e tests in the openshift/network/virtualization suite (e2e-metal-ipi-ovn-bgp-virt-* jobs) whose iperf server/client test pods use ghcr.io/nicolaka/netshoot:v0.13. The image is not in the mirrored test image set, so the known-image-checker MonitorTest fails those jobs and the pods cannot run in disconnected environments. Add it to the pre-approved image list so it gets mirrored, following the precedent of the fedora-with-test-tooling containerdisk entry used by the same tests. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
3066aab to
70a6d63
Compare
|
New changes are detected. LGTM label has been removed. |
|
Scheduling required tests: |
|
@qinqon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
The ovn-kubernetes payload tests extension runs kubevirt e2e tests in the
openshift/network/virtualizationsuite (e2e-metal-ipi-ovn-bgp-virt-*jobs) whose iperf server/client test pods useghcr.io/nicolaka/netshoot:v0.13. The image is not in the mirrored test image set, so theknown-image-checkerMonitorTest fails those jobs — currently the only hard MonitorTest failure keeping them red (see e.g. this run) — and the pods cannot run in disconnected environments.Add it to the pre-approved image list so it gets mirrored, following the precedent of the
quay.io/kubevirt/fedora-with-test-tooling-container-diskentry used by the same tests ("used by KubeVirt test to start fedora VMs").The image needs
bash,jq,iproute2(ip -j) andiperf3;quay.io/openshifttest/iperf3(referenced by the SRIOV testdata) was evaluated as an alternative and rejected — it is a 2018 Alpine 3.5 image without bash/jq and itsipdoes not support JSON output.Enablement PR on the ovn-kubernetes side: openshift/ovn-kubernetes#3292(tracked in [CNV-92760])
Depends-On:
Summary by CodeRabbit
Summary by CodeRabbit
ghcr.io/nicolaka/netshoot:v0.13for image-related test runs.