Conversation
7 of 13 tasks
Pandapip1
force-pushed
the
ime-probing
branch
4 times, most recently
from
August 6, 2026 15:24
55d3dc2 to
459d0a3
Compare
Pandapip1
added a commit
to Pandapip1/plover
that referenced
this pull request
Aug 6, 2026
Pandapip1
marked this pull request as ready for review
August 6, 2026 23:29
Pandapip1
added a commit
to Pandapip1/plover
that referenced
this pull request
Aug 6, 2026
Pandapip1
added a commit
to Pandapip1/plover
that referenced
this pull request
Aug 6, 2026
Contributor
Author
|
Bump, it's been ~1 month |
Pandapip1
force-pushed
the
ime-probing
branch
from
September 5, 2026 20:57
0e038f1 to
f0706de
Compare
Contributor
Author
|
Fixed ruff failure |
Contributor
|
Hi, thank you so much for this PR! I'm currently moving so I won't find time for this the next few weeks, but it's not forgotten. Any review or comment from other contributors is very welcome of course! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
On certain distributions, certain programs (such as the ibus or fcitx daemons) get wrapped. This causes the process name to be different and the check with the hardcoded name to fail.
This instead checks for the presence of the actual D-Bus APIs, which is the correct way of determining if the service is running or not.
Currently uses raw FFI to avoid pulling in any additional dependencies, LMK if you'd prefer I just bring in one of the python D-Bus libraries (which would simplify things a lot).
Pull Request Checklist