Conversation
With these "duration" values, the test groups are split from largest to least, so to balance each VMs time, and also print each vm's running time in Test Summary. Signed-off-by: tiehexue <tiehexue@hotmail.com>
|
According to latest CI results: the most closed between VMs is ubuntu24, differs in seconds, and biggest bias is ubuntu22, around 30 minutes. Ubuntu22 is the one that one of the VMs timeout in 270 minutes, and now it is 215 minutes. |
|
@tiehexue I was working on something very similar to this PR but you beat me to to it: #19084. I'm seeing the same results as you where most of the tests are now really balanced except for Alma 8 and Ubuntu 22, which finish ~30min between vm1 and vm2. Some differences with my PR:
|
|
Hi @tonyhutter , I am pretty fine for your PR which is very professional. Either of this two PR merge, should close the other.
Actually, this is the "intention" in my PR, we should care about tests we added. However, your points are very sound. And one more thing, it will be good to add a summary in "Test Summary" section to show each VM's timing explicitly. |
|
@tiehexue thanks for posting this so quickly! After reading through both versions I'd like to move forward with #19084, so I'm going to close this PR.
Good idea, making it easy see the VM run times would be helpful. It would be nice to have the VM exit status there as well. |
Motivation and Context
As discussed in #18997 , we could make the two VMs in ZTS more balanced by the actual time cost.
Description
The methodology is very simple: 1) added a new key "duration" for each test group; 2) set duration value by a real run (ubuntu22 is picked in this PR); 3) split tags based the test group duration, sorted by duration desc first, and each vm picks one by one.
We also could let one vm pick one, and the second vm pick following several ones to best match the first one. But consider that we have "a lot" test group, the one-by-one is quite good. The Lustre build and in-kernel build is not considered too for simplicity.
Now the two vm differs in less than 20 minutes, e.g.:
How Has This Been Tested?
CI of zfs fork
Types of Changes
Checklist
Signed-off-by.