Repository navigation
Add error_on_overwrite option in attr-related storage apis - #5
Merged
Merged
Conversation
c-bata
commented
Dec 5, 2025
| param_name: String, | ||
| choices: Vec<PyObject>, | ||
| ) -> PyResult<()> { | ||
| // TODO(c-bata): Add validation to detect changes of the choices. |
Member
Author
There was a problem hiding this comment.
Note: The main motivation for introducing error_on_overwrite option is resolving this todo item.
c-bata
force-pushed
the
c-bata/set-attr-error-on-overwrite
branch
from
December 5, 2025 04:32
7265627 to
0f9eb1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
CategoricalDistribution's choices field is stored in study_system_attrs. For the atomic updates, this PR introduceserror_on_overwriteoption toset_study_attrs()andset_trial_attrsstorage methods.