Repository navigation
Fix(plugin/virtual_scroll): allow resetting preloaded default options via clearDefaultOptions - #1090
Open
dee-ene-gee wants to merge 1 commit into
Open
dee-ene-gee wants to merge 1 commit into
dee-ene-gee wants to merge 1 commit into
Conversation
… via clearDefaultOptions
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR addresses an issue where the
virtual_scrollplugin permanently caches the initial empty-query preloaded options inside private closure variables (default_values,default_options,default_pagination,default_values_loaded).When an external dynamic filter or URL parameter changes
firstUrl, closing the dropdown or clearing a search (query === '') causesrestoreDefaults()to reload the stale original options.This PR adds a
clearDefaultOptions()method to the TomSelect instance when usingvirtual_scroll, allowing developers to reset the cached default state when underlying filter context changes.What Changed?
self.clearDefaultOptions()on the instance withinvirtual_scroll.ts.default_values,default_options,default_pagination,default_values_loaded, and calledclearPagination()inside the method.clearDefaultOptions()resets cached defaults so new options are captured upon subsequent loads.Fixes #1086
How to Test
virtual_scroll.instance.clearDefaultOptions()andinstance.clearOptions().instance.load('')with new results.