Offer to code review this repo's Bash

[ingydotnet]

I've looked over the Bash code in this repo and many things are very good, but a lot of things could be improved.

I've been using Bash for 10 years now, as seriously as I use Perl, Ruby, Python, Node etc.
I've even recently written a Bash package management system (CPAN, RubyGems, PyPI, NPM) called BPAN.

I'd like to offer a code review of this repo for you. I'll make lots of suggestions and you can choose to apply the ones you like.
Most of the suggestions would just be minor syntax refactoring. Nothing (or very little) would be a major change suggestion.

But before I do, please let me know whether or not this would be appreciated.

Cheers, Ingy

[okurz]

Sure, you already helped in previous pull requests and I would be happy to see more suggestions

[ingydotnet]

Great. I think this will be fun and I'm sure I'll end up learning a lot as well. I still am constantly learning new/better ways to do things with Bash.

@okurz I started #209 with a dumb commit. I think making each suggestion a commit of just a couple lines, but a full explanation in the commit message might be a decent way to do this. If you agree then please say so in a comment or a 👍 in #209 and I'll get started. :)

[okurz]

Yep, good approach

[okurz]

thanks for the bash script review. Since the initial issue we also could extend test coverage and improve style. Meanwhile for more complex scripts we reworked those in Python which IMHO provides more streamlined, easier and also faster tooling to ensure good style and test coverage