Conversation
Motivation: Allow connecting to authenticated LLM APIs (e.g. OpenAI, Anthropic, Gemini proxies). Design Choices: Read LLM_API_TOKEN from the environment and inject it as a Bearer token in the Authorization header of the HTTP POST request. Benefits: Enables openqa-llm-investigate to be used with a wider range of hosted or remote LLM models.
foursixnine
approved these changes
Sep 18, 2026
Martchus
approved these changes
Sep 18, 2026
perlpunk
requested changes
Sep 18, 2026
| dir = (tmp_path / "git-repos" / package).mkdir(parents=True, exist_ok=True) | ||
| return "foo/" + package | ||
| _dir = (tmp_path / "git-repos" / package).mkdir(parents=True, exist_ok=True) | ||
| return str(tmp_path / "git-repos" / package) |
Contributor
There was a problem hiding this comment.
That's wrong. This should not return a path, but the repo owner/org and repo name.
What's the relation to the LLM PR anyway?
Member
Author
There was a problem hiding this comment.
What's the relation to the LLM PR anyway?
See the commit message. I locally observed style issues reported. I will try if I can leave those commits separate. Maybe our CI environment is using older versions of tooling and don't immediately need those fixes.
Member
Author
There was a problem hiding this comment.
I left out the style changes for now. Separate PR following this one:
Motivation: Allow users to specify LLM settings via CLI arguments. Design Choices: Updated typer options to include --llm-url, --llm-model, and --llm-token, mapping them to their respective envvars. Benefits: Better usability for configuring the LLM API endpoint.
okurz
force-pushed
the
feature/llm_investigate_auth
branch
from
September 18, 2026 16:53
c10a719 to
b44e394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Allow users to specify LLM settings via CLI arguments.
Design Choices:
Updated typer options to include --llm-url, --llm-model, and --llm-token,
mapping them to their respective envvars.
Benefits:
Better usability for configuring the LLM API endpoint.